Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #34345 -- Added system check for ManyToManyFields with intermediate tables in ModelAdmin.filter_horizontal/vertical. #16983

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fixed #34345 -- Added system check for ManyToManyFields with intermediate tables in ModelAdmin.filter_horizontal/vertical. #16983

merged 1 commit into from
Jun 21, 2023

Conversation

hrushikeshrv
Copy link
Contributor

Started work on patch. Yet to add documentation and tests.

@hrushikeshrv hrushikeshrv marked this pull request as ready for review June 20, 2023 02:20
felixxm
felixxm reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrushikeshrv Thanks 👍 I left small comments.

tests/modeladmin/test_checks.py Outdated Show resolved Hide resolved
tests/modeladmin/test_checks.py Outdated Show resolved Hide resolved
tests/modeladmin/models.py Outdated Show resolved Hide resolved
@felixxm felixxm changed the title Fixed #34345 -- Add system check for filter_horizontal/filter_vertical on ManyToManyFields with intermediary models. Fixed #34345 -- Added system check for ManyToManyFields with intermediate tables in ModelAdmin.filter_horizontal/vertical. Jun 20, 2023
@hrushikeshrv @felixxm
Fixed #34345 -- Added system check for ManyToManyFields with intermed…
1078657 
…iate tables in ModelAdmin.filter_horizontal/vertical.
@felixxm felixxm merged commit 1078657 into django:main Jun 21, 2023
35 checks passed
@felixxm felixxm temporarily deployed to schedules June 22, 2023 02:50 — with GitHub Actions Inactive
@felixxm felixxm temporarily deployed to schedules June 23, 2023 03:02 — with GitHub Actions Inactive
@SchoolGuy SchoolGuy mentioned this pull request Jan 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hrushikeshrv @felixxm